Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pass undefined height in image sizes #22

Open
fredrikekelund opened this issue Jan 22, 2018 · 0 comments
Open

Add ability to pass undefined height in image sizes #22

fredrikekelund opened this issue Jan 22, 2018 · 0 comments

Comments

@fredrikekelund
Copy link

I've been using this module as part of Apostrophe. It does its job very well, but there's one issue (which also relates to the proposed srcset functionality) I'd like to bring up. Namely the fact that I would like to be able to set an undefined height in image sizes. It seems to me like a more common scenario, that you would want to be 100% sure of the width of an image, but let the height be flexible.

I have achieved the same behavior today by setting a very high number for the height parameter. But the behavior of width and height isn't very documented, and passing something like 20000 for the height feels like a hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant