Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Nunjucks syntax for accessing _seoCanonical URL #10

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stepanjakl
Copy link

Summary

The original code is attempting to access a property that doesn't exist on the array object, the associated page reference is only accessible as the first item of the array.

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

@stepanjakl
Copy link
Author

Hello team, did you get a chance to review this PR?

@BoDonkey BoDonkey requested a review from falkodev March 27, 2023 18:46
@BoDonkey
Copy link
Contributor

Not sure if this PR remains valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants