Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the broken parked page imports #82

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

boutell
Copy link
Member

@boutell boutell commented Sep 5, 2024

Phew

@boutell boutell requested a review from haroun September 5, 2024 18:43
@boutell boutell requested review from BoDonkey and removed request for BoDonkey September 5, 2024 18:53
lastPublishedAt: 1
});
if (existingDoc) {
doc.lastPublishedAt = existingDoc.lastPublishedAt;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was the lastPublishedAt thing important?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's going to get that automatically because we always start with the actual doc as found in the database and apply convert to update properties actually present in the imported doc and the schema, which will leave lastPublishedAt unchanged

@boutell boutell requested a review from haroun September 5, 2024 19:00
@boutell boutell merged commit a4830d4 into main Sep 5, 2024
6 checks passed
@boutell boutell deleted the fix-broken-updates-for-pages branch September 5, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants