Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form group as area not array #41

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Conversation

haroun
Copy link
Contributor

@haroun haroun commented Oct 27, 2023

Summary

Form group widget is not an array of area

What are the specific steps to test this change?

  1. Form group widget is not an array anymore and can be edited in the page

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@haroun haroun self-assigned this Oct 27, 2023
@haroun haroun requested a review from boutell October 27, 2023 10:18
Copy link
Member

@boutell boutell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor language things, and please fix eslint.

i18n/en.json Outdated
@@ -61,11 +61,10 @@
"group": "Group",
"groupAdvanced": "Advanced",
"groupAfterSubmission": "After submission",
"groupContents": "Groups Contents",
"groupContentsHelp": "Contains all form widgets excepts groups",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except

i18n/en.json Outdated
@@ -61,11 +61,10 @@
"group": "Group",
"groupAdvanced": "Advanced",
"groupAfterSubmission": "After submission",
"groupContents": "Groups Contents",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Group Contents

contents: {
label: 'aposForm:groupContents',
help: 'aposForm:groupContentsHelp',
type: 'area',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@haroun haroun requested a review from boutell October 27, 2023 13:14
@haroun haroun merged commit d4eb55e into main Oct 27, 2023
6 checks passed
@haroun haroun deleted the feature/form-group-edit-experience branch October 27, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants