-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
form group as area not array #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor language things, and please fix eslint.
i18n/en.json
Outdated
@@ -61,11 +61,10 @@ | |||
"group": "Group", | |||
"groupAdvanced": "Advanced", | |||
"groupAfterSubmission": "After submission", | |||
"groupContents": "Groups Contents", | |||
"groupContentsHelp": "Contains all form widgets excepts groups", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except
i18n/en.json
Outdated
@@ -61,11 +61,10 @@ | |||
"group": "Group", | |||
"groupAdvanced": "Advanced", | |||
"groupAfterSubmission": "After submission", | |||
"groupContents": "Groups Contents", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Group Contents
contents: { | ||
label: 'aposForm:groupContents', | ||
help: 'aposForm:groupContentsHelp', | ||
type: 'area', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Summary
Form group widget is not an array of area
What are the specific steps to test this change?
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: