Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detectDocChange now returns true when one of the docs contains modified: true #4783

Closed
wants to merge 1 commit into from

Conversation

ETLaurent
Copy link
Contributor

Summary

See apostrophecms/import-export#95

What are the specific steps to test this change?

For example:

  1. Run the website and log in as an admin
  2. Open a piece manager modal and select several pieces
  3. Click the "Archive" button on the top left of the manager and confirm that it should proceed
  4. Check that all pieces have been archived properly

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@ETLaurent
Copy link
Contributor Author

@ETLaurent
Copy link
Contributor Author

Closing this PR because it makes too may regressions: https://github.com/apostrophecms/testbed/actions/runs/11581041489/job/32241041225

@ETLaurent ETLaurent closed this Oct 30, 2024
@ETLaurent ETLaurent deleted the pro-6696-import-as-draft branch October 30, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant