Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for moduleIf in context operations #4268

Merged
merged 3 commits into from
Aug 15, 2023
Merged

support for moduleIf in context operations #4268

merged 3 commits into from
Aug 15, 2023

Conversation

boutell
Copy link
Member

@boutell boutell commented Aug 14, 2023

Summary

Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"

What are the specific steps to test this change?

See corresponding doc-template-library PR

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@boutell boutell requested a review from BoDonkey August 14, 2023 14:01
@linear
Copy link

linear bot commented Aug 14, 2023

PRO-4648 Making templates for images, image tags, files, and file tags does not make sense

The list of types you can pick from is long and contains things that are silly.

We need an easy, documented way to suppress this option on a per-type basis, via an option to that type's module, and we need to use "improve" to apply those to some standard types in the doc-template-library module.

PRO-4684 "Save As Template" offered for inappropriate types

Users, for instance.

BoDonkey
BoDonkey previously approved these changes Aug 14, 2023
@boutell
Copy link
Member Author

boutell commented Aug 15, 2023

Merge conflicts resolved. Same changes.

@boutell boutell merged commit 48ea787 into main Aug 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants