Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Commit

Permalink
Refactored internal implementations to drive HOCs by Components inste…
Browse files Browse the repository at this point in the history
…ad of separate components

* initial bulk work on merging implementations

* all tests passing execept subscriptions and query recycler

* clean up files

* clean up files bug introduced rerender bug

* removed old dead code

* updated changelog

* move to using npm over yarn

* sideEffects false for webpack shake

* remove yarn cache

* fix preact tests

* updates from Dirk's review 🎉

* Add failing test for unmount component error

* Fix typo

* handle error phase

* remove extra package-lock for right now

* clean up boolean check in subscription hoc

* clean up boolean check in query-hoc

* clean up tslint errors
  • Loading branch information
James Baxley committed Feb 26, 2018
1 parent d57f252 commit ed75b71
Show file tree
Hide file tree
Showing 31 changed files with 9,604 additions and 6,366 deletions.
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ dist
npm
.reports

# don't track package-lock but allow contributors to use it for local dev
package-lock.json
# don't track yarn.lock but allow contributors to use it for local dev
yarn.lock

.vscode
2 changes: 0 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ language: node_js
node_js:
- "8"

cache: yarn

script:
- npm run danger
- npm test
Expand Down
6 changes: 6 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

### vNext

### 2.1.0-beta.3

* Refactored and removed old `graphql` implementation in favor of new components
* Removed QueryRecycler!! :yay:
* Added `query`, `mutation`, and `subscription` higher order components
* Aded `<Subscription />` to the public API
* Added `prop-types` validation to the `<Query />`, `<Subscription />` and `<ApolloConsumer />` component [#1587](https://github.com/apollographql/react-apollo/pull/1587)
* Added `<Mutation />` component [#1520](https://github.com/apollographql/react-apollo/pull/1520)
* HoC `props` result-mapping function now receives prior return value as second argument.
Expand Down
1 change: 1 addition & 0 deletions jest.preact.config.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"<rootDir>/test/client/ApolloProvider.test.tsx",
"<rootDir>/test/client/Query.test.tsx",
"<rootDir>/test/client/Mutation.test.tsx",
"<rootDir>/test/client/Subscription.test.tsx",
"<rootDir>/test/internal-api/",
"<rootDir>/test/test-utils.test.tsx"
],
Expand Down
Loading

1 comment on commit ed75b71

@525c1e21-bd67-4735-ac99-b4b0e5262290

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.