Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ESM package version #152

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

d3c0d3dpt
Copy link

@apollo/server inspired ESM build configs to provide a version of @as-integrations/aws-lambda compiled to ESM, together with the existing CJS version.

Copy link

changeset-bot bot commented Nov 16, 2023

🦋 Changeset detected

Latest commit: ff57d67

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@as-integrations/aws-lambda Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Nov 16, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ff57d67:

Sandbox Source
apollo-server-integration-aws-lambda Configuration

@trevor-scheer
Copy link
Member

I like the idea of this, but I don't think Apollo Server has it right currently, so I'm reluctant to adopt the same pattern until we figure out the right one. I unfortunately haven't had time to investigate this and I'm not sure when that might happen.
Ref: apollographql/apollo-server#7625

@rsteele1-seic
Copy link

Hi ALL! I got here from apollographql/apollo-server#7625 and neither of these issues seem to have been touched since Nov '23. I was trying to jump on the Apollo V3 deprecation as of Nov '24, but our entire codebase is ESM and we are having the ESM/CJS conflict on this line of code
export const graphqlHandler = startServerAndCreateLambdaHandler(server, requestHandler);
with the following error
error TS2345: Argument of type 'import("/src/testapollo/node_modules/@apollo/server/dist/esm/ApolloServer", { assert: { "resolution-mode": "import" } }).ApolloServer<import("/src/testapollo/node_modules/@apollo/server/dist/esm/externalTypes/context", { assert: { "resolution-mode": "import" } }).BaseContext>' is not assignable to parameter of type 'import("/src/testapollo/node_modules/@apollo/server/dist/cjs/ApolloServer").ApolloServer<import("/src/testapollo/node_modules/@apollo/server/dist/cjs/externalTypes/context").BaseContext>'. Types have separate declarations of a private property 'internals'.

Is there any update to a timeline on this issue?

@deldrid1
Copy link

deldrid1 commented Sep 4, 2024

Any updates on this? Seems like this should be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants