-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide ESM package version #152
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: ff57d67 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ff57d67:
|
I like the idea of this, but I don't think Apollo Server has it right currently, so I'm reluctant to adopt the same pattern until we figure out the right one. I unfortunately haven't had time to investigate this and I'm not sure when that might happen. |
Hi ALL! I got here from apollographql/apollo-server#7625 and neither of these issues seem to have been touched since Nov '23. I was trying to jump on the Apollo V3 deprecation as of Nov '24, but our entire codebase is ESM and we are having the ESM/CJS conflict on this line of code Is there any update to a timeline on this issue? |
Any updates on this? Seems like this should be merged? |
@apollo/server
inspired ESM build configs to provide a version of@as-integrations/aws-lambda
compiled to ESM, together with the existing CJS version.