Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: add usage trends of Crawlee package suite #2502

Closed
wants to merge 1 commit into from

Conversation

cwtuan
Copy link

@cwtuan cwtuan commented May 26, 2024

I am an enthusiastic user of the Crawlee package, and I truly appreciate all the hard work and dedication that has gone into its development. Crawlee has been an invaluable tool in my projects.

I'd like to propose a small addition to the README to benefit new users. This could involve highlighting the different packages within Crawlee or showcasing its popularity to attract more users.

I believe this small addition will provide significant value to both new and existing users of Crawlee. I hope you consider merging this change to help enhance the user experience and visibility of the Crawlee package suite.

@cwtuan cwtuan changed the title usage trends of Crawlee package suite chore!: add usage trends of Crawlee package suite May 27, 2024
@B4nan
Copy link
Member

B4nan commented May 27, 2024

Thanks for the PR but we are not interested in adding this to the readme, I personally don't see a value in having it there.

Also note that the changes are not even valid, you are combining HTML with markdown.

@B4nan B4nan closed this May 27, 2024
@janbuchar
Copy link
Contributor

@B4nan it's legit to write HTML (or a restricted subset of it) in Markdown in some cases, for example when you want to do target="_blank" 🙂 But I do agree we don't need this.

image

@B4nan
Copy link
Member

B4nan commented May 28, 2024

What the PR is doing is not correct, you can't put markdown inside HTML attribute.

@janbuchar
Copy link
Contributor

What the PR is doing is not correct, you can't put markdown inside HTML attribute.

Oooh, right, now I see it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants