feat: remove side effect from the deprecated error context augmentation #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4nan
approved these changes
Sep 7, 2023
barjin
force-pushed
the
fix/error-context-aug
branch
from
419d225
to
b766d81
Compare
|
Due to the failing tests, I had to update the tests suites a bit (remove the equality test since the base While the other tests are passing, it makes me think - is spread copy enough in this case? |
barjin
force-pushed
the
fix/error-context-aug
branch
from
b766d81
to
7fb05a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the trend of removing side-effects from the Crawlee codebase, this one looks pretty unintentional - the augmented context is passed to a handler, but the changes persist even after the handler is executed.
Fixes #2068