Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correctly handle log level configuration #508

Merged
merged 3 commits into from
Sep 10, 2024
Merged

fix: Correctly handle log level configuration #508

merged 3 commits into from
Sep 10, 2024

Conversation

janbuchar
Copy link
Collaborator

  • The CRAWLEE_VERBOSE and CRAWLEE_LOG_LEVEL variables are now respected by crawlee
  • CrawleeLogFormatter doesn't alter the record being formatted anymore
  • SDK counterpart coming soon

@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Sep 9, 2024
@janbuchar janbuchar added the adhoc Ad-hoc unplanned task added during the sprint. label Sep 9, 2024
@github-actions github-actions bot added this to the 98th sprint - Tooling team milestone Sep 9, 2024
vdusek
vdusek requested changes Sep 10, 2024
View reviewed changes
src/crawlee/configuration.py Outdated Show resolved Hide resolved
src/crawlee/basic_crawler/_basic_crawler.py Show resolved Hide resolved
src/crawlee/_log_config.py Show resolved Hide resolved
vdusek
vdusek approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the CRITICAL thing, otherwise LGTM 🚀

@janbuchar janbuchar merged commit 7ea8fe6 into master Sep 10, 2024
19 checks passed
@janbuchar janbuchar deleted the logging-config branch September 10, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

Assignees

@janbuchar janbuchar

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
98th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@janbuchar @vdusek