Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing __all__ to top-level __init__.py file #463

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

janbuchar
Copy link
Collaborator

Without the top-level __all__, pyright screams at from crawlee import Request, for example

@janbuchar janbuchar added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Aug 26, 2024
@janbuchar janbuchar requested a review from vdusek August 26, 2024 12:24
@github-actions github-actions bot added this to the 97th sprint - Tooling team milestone Aug 26, 2024
@janbuchar janbuchar changed the title fix: Add missing top-level __init__.py file fix: Add missing __all__ to top-level __init__.py file Aug 26, 2024
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

If issue is not linked to the pull request then estimate the pull request!

@janbuchar janbuchar merged commit 353a1ce into master Aug 26, 2024
20 checks passed
@janbuchar janbuchar deleted the missing-top-level-all branch August 26, 2024 12:32
@janbuchar janbuchar restored the missing-top-level-all branch August 26, 2024 12:33
@vdusek vdusek deleted the missing-top-level-all branch September 16, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants