Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: storage-related models are in base storage client #461

Merged
merged 1 commit into from
Aug 26, 2024
Merged

refactor: storage-related models are in base storage client #461

merged 1 commit into from
Aug 26, 2024

Conversation

vdusek
Copy link
Collaborator

@vdusek vdusek commented Aug 26, 2024 •
edited
Loading

Description

  • refactor: storage-related models are in base storage client
  • basically I just split crawlee/_models.py to crawlee/_request.py and crawlee.base_storage_client._models.py

Issues

Testing

  • Tests are passing

Checklist

  • CI passed

@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. debt Code quality improvement or decrease of technical debt. labels Aug 26, 2024
@vdusek vdusek added this to the 97th sprint - Tooling team milestone Aug 26, 2024
@vdusek vdusek requested a review from janbuchar August 26, 2024 07:52
@vdusek vdusek self-assigned this Aug 26, 2024
github-actions[bot]
github-actions bot reviewed Aug 26, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@vdusek vdusek added the adhoc Ad-hoc unplanned task added during the sprint. label Aug 26, 2024
janbuchar
janbuchar approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek merged commit 5b26298 into master Aug 26, 2024
22 checks passed
@vdusek vdusek deleted the refactor-storage-related-models branch August 26, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@janbuchar janbuchar janbuchar approved these changes

Assignees

@vdusek vdusek

Labels
adhoc Ad-hoc unplanned task added during the sprint. debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
97th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@vdusek @janbuchar