-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: declare private and public interface #456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
35dfde7
to
ea3e1de
Compare
ea3e1de
to
f966400
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
### Description - refactor: storage-related models are in base storage client - basically I just split `crawlee/_models.py` to `crawlee/_request.py` and `crawlee.base_storage_client._models.py` ### Issues - Just a follow-up of #456 ### Testing - Tests are passing ### Checklist - [x] CI passed
Description
Issues
Testing
Checklist