Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: purge request queue on repeated crawler runs #377

Merged
merged 4 commits into from
Jul 30, 2024
Merged

fix: purge request queue on repeated crawler runs #377

merged 4 commits into from
Jul 30, 2024

Conversation

janbuchar
Copy link
Collaborator

@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Jul 30, 2024
@janbuchar janbuchar requested a review from vdusek July 30, 2024 08:26
@github-actions github-actions bot added this to the 95th sprint - Tooling team milestone Jul 30, 2024
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Jul 30, 2024
vdusek
vdusek approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just CI - probably missing a new line character at the end of the test file.

@janbuchar janbuchar merged commit 7ad3d69 into master Jul 30, 2024
20 checks passed
@janbuchar janbuchar deleted the purge-request-queue-on-repeated-crawler-runs branch July 30, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

Assignees

@janbuchar janbuchar

Labels
t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
95th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.

Implement purging request queue in repeated BasicCrawler.run calls
2 participants
@janbuchar @vdusek