Line break fix #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @SunboX, thanks for the contribution! I'm sorry it took us so long to look at this. That won't happen again! Do you think we could solve this with following? .split(/\r?\n/) |
|
Hi, don't know. It's some time now. ;) But the related issue has a test case referenced. So you should be able to try it out. I'm sadly haven't the time right now. |
|
+1 |
|
@roccomuso Would you be willing to send an equivalent PR with my comment about |
|
@honzajavorek OK, It works also with your solution. It Would be good to have this added as a test-case in the tests. PS. also found a typo in a test. |
|
Closed by #7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #4