Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: loosen ramda dependency range for openapi3-parser #653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tklever
Copy link

@tklever tklever commented Jun 20, 2022

Goal: Widen ramda dependency range to allow use of version [email protected] in openapi3-parser.

Adding the carat in openapi3-parser's dependency configuration is consistent with the use of ramda in the api-elements package in this same monorepo:

Additionally, allowing downstream consumers to utilize [email protected] allows them to use a version which includes this security fix ramda/ramda#3177

Bigger picture, as both of the libraries mentioned are included in the dependency tree of dredd (by way of dredd-transactions), unifying their use of this dependency will allow deduplication when using that project. The two independent versions of ramda can be seen here

└─┬ [email protected]
  ├─┬ [email protected]
  │ ├─┬ @apielements/[email protected]
  │ │ └─┬ [email protected]
  │ │   └── [email protected]
  │ └─┬ @apielements/[email protected]
  │   └── [email protected]

Alternatives

This dependency could be updated to ^0.28.0, which is latest at time of writing, but this change seemed less invasive and aligned api-elements and openapi3-parser to be upgraded in tandem later

Widen ramda dependency range to allow use of 0.27.2, which includes the release of this fix: ramda/ramda#3177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant