feat: support manager-api systemd startup script #36
Conversation
dockerfiles/Dockerfile.dashboard.rpm
Outdated
| @@ -31,6 +32,8 @@ RUN set -x \ | |||
| && mkdir gopath \ | |||
| && go env -w GOPROXY=https://goproxy.cn,direct \ | |||
| && cd /tmp/ \ | |||
| # add startup script | |||
| && curl --silent --location https://raw.githubusercontent.com/totemofwolf/apisix-build-tools/service/deps/manager-api.service | tee /tmp/build/output/apisix/dashboard/usr/lib/systemd/system/manager-api.service \ | |||
There was a problem hiding this comment.
@totemofwolf I was wondering that if we should use the manager-api.service file within this commit? Thanks.
There was a problem hiding this comment.
It looks like you have put it in deps/manager-api.service, so don't need to download it, just need to mv...
There was a problem hiding this comment.
It looks like you have put it in
deps/manager-api.service, so don't need to download it, just need tomv...
Yes u r right. But now I can't find a suitable way to do this. ;-)
There was a problem hiding this comment.
hi @totemofwolf,
I think we also need to add documentation on how to start and stop with service.
others LGTM. Thanks!
Add it in README.md ? or |
README.md is OK |
|
ping @totemofwolf |
|
Maybe we can add test cases to cover it. |
|
|
No description provided.