fix: implement admin permissions #429
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
reviewed
Jul 12, 2024
pwa/components/admin/Admin.tsx
Outdated
| @@ -116,6 +117,7 @@ const AdminWithContext = ({ session }: { session: Session }) => { | |||
| const AdminWithOIDC = () => { | |||
| // Can't use next-auth/middleware because of https://github.com/nextauthjs/next-auth/discussions/7488 | |||
| const { data: session, status } = useSession(); | |||
| const { permissions } = usePermissions(); | |||
There was a problem hiding this comment.
usePermissions can only be called by children of react-admin's <Admin> component (otherwise there is no AuthProviderContext and QueryClientContext available). That's why you have an error.
The proper fix would be to call the usePermissions in BookList and other admin-only components, and redirect to a /forbidden CustomRoute if the permissions don't match.
fzaninotto
reviewed
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427