Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in line 528... and after #5

Open
gszeleczki opened this issue Dec 17, 2013 · 3 comments
Open

in line 528... and after #5

gszeleczki opened this issue Dec 17, 2013 · 3 comments

Comments

@gszeleczki
Copy link

...&&((_ptr)/right <= 3.0 || right/(_ptr) <= 3.0)

Correct me if I am wrong, but this is always true. If You have two real numbers, like 'a' and 'b', a/b or b/a should be less than 1. I think because of this, things get connected which should not be, and we will have huge components.

@achalddave
Copy link

👍 This definitely seems to be the case. It seems like you want to check to make sure the values are close to each other, but I'm not sure if that's what they're trying to do.

Perhaps ((*ptr) / right <= 3.0) && (right / (*ptr) <= 3.0)? This would ensure that (*ptr) and right are within a factor of 3 of each other.

@aperrault
Copy link
Owner

I believe that @achalddave has it right. You will probably need to adjust the other filters if you make this change. I haven't had a chance to test it.

The other piece of feedback I've gotten is to add a check for a minimum height on each component (line 697).

@achalddave
Copy link

I've also had luck with eroding the components by a small value and seeing if they still exist; this is not in the paper, but it performed better than the height check as it also gets rid of thin diagonal lines (achalddave/Kannada-Text-Detection@ba0eb48)

xc-racer99 added a commit to xc-racer99/android-camera-timing-pc that referenced this issue Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants