From c8987b8002b62c43afdce753056c98acd7d4cd91 Mon Sep 17 00:00:00 2001
From: rrajesh <rrajesh@cloudera.com>
Date: Fri, 6 Sep 2024 10:10:48 -0500
Subject: [PATCH] [YUNIKORN-2852] Add e2e tests for group names in placement
 rule filter (#908)

Closes: #908

Signed-off-by: Craig Condit <ccondit@apache.org>
---
 test/e2e/configmap/configmap_test.go | 59 ++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)

diff --git a/test/e2e/configmap/configmap_test.go b/test/e2e/configmap/configmap_test.go
index 15cfb0958..6f3649c92 100644
--- a/test/e2e/configmap/configmap_test.go
+++ b/test/e2e/configmap/configmap_test.go
@@ -24,6 +24,7 @@ import (
 	"io"
 	"time"
 
+	"github.com/onsi/ginkgo/v2"
 	"github.com/onsi/gomega"
 	v1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -209,6 +210,64 @@ partitions:
 		gomega.Ω(invalidConfigErr).Should(gomega.HaveOccurred())
 	})
 
+	ginkgo.It("Configure the scheduler with a valid group name in placement rule filter", func() {
+		validConfig := `
+partitions:
+  - name: default
+    placementrules:
+      - name: fixed
+        value: root_Test-a_b_#_c_#_d_/_e@dom:ain
+        create: true
+        filter:
+          type: allow
+          groups:
+            - group1
+            - group_Test-a_b_#_c_#_d_/_e@dom:ain.com
+    queues:
+      - name: root
+        submitacl: '*'
+`
+		data := map[string]string{"queues.yaml": validConfig}
+		validConfigMap := &v1.ConfigMap{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      constants.ConfigMapName,
+				Namespace: configmanager.YuniKornTestConfig.YkNamespace,
+			},
+			Data: data,
+		}
+		cm, err := kClient.UpdateConfigMap(validConfigMap, configmanager.YuniKornTestConfig.YkNamespace)
+		gomega.Ω(err).ShouldNot(gomega.HaveOccurred())
+		gomega.Ω(cm).ShouldNot(gomega.BeNil())
+	})
+
+	ginkgo.It("Configure the scheduler with an invalid group name in placement rule filter", func() {
+		invalidConfig := `
+partitions:
+  - name: default
+    placementrules:
+      - name: fixed
+        value: root_Test-a_b_#_c_#_d_/_e@dom:ain
+        create: true
+        filter:
+          type: allow
+          groups:
+            - group_inva!lid
+    queues:
+      - name: root
+        submitacl: '*'
+`
+		data := map[string]string{"queues.yaml": invalidConfig}
+		invalidConfigMap := &v1.ConfigMap{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      constants.ConfigMapName,
+				Namespace: configmanager.YuniKornTestConfig.YkNamespace,
+			},
+			Data: data,
+		}
+		_, err := kClient.UpdateConfigMap(invalidConfigMap, configmanager.YuniKornTestConfig.YkNamespace)
+		gomega.Ω(err).Should(gomega.HaveOccurred())
+	})
+
 	AfterEach(func() {
 		tests.DumpClusterInfoIfSpecFailed(suiteName, []string{"default"})
 		yunikorn.RestoreConfigMapWrapper(oldConfigMap)