Wicket 7125 set bean manager #1022
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrosans
force-pushed
the
WICKET-7125-setBeanManager
branch
3 times, most recently
from
e7fe6d3
to
c4baa33
Compare
|
I guess we also need to create a separate branch for 10.x since this feature is the first targeted for version 11. No big deal, I can do it in the next days before merging this PR |
|
I see no reason to keep this only for 11.x. |
|
@martin-g my concern is if it is legit introducing a new module for API compatibility. Maybe we can use japicmp-maven-plugin to test if this change is acceptable. |
|
The new module is only for tests. |
pedrosans
force-pushed
the
WICKET-7125-setBeanManager
branch
from
3bf08d1
to
b548c8b
Compare
pedrosans
force-pushed
the
WICKET-7125-setBeanManager
branch
from
5d6bd76
to
7a3237b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New CdiConfiguration.setBeanManager method enabling unit tests to configure cdi-unit's BeanManager in the application