Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYSTEMDS-2650] Standardize deduplicated lineage trace serialization … #2072

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phaniarnab
Copy link
Contributor

…format

This patch standardizes the dedup patch serialization format, regardless of if they are captured by the lineage() built-in or via a write operator. Previously, all patches were stored in a separate file. Now, we always create a single file, containing first the global trace, followed by the patches. This change also allows us to copy the traces from the console (lineage()) and store them in a single file for future recomputation.

…format

This patch standardizes the dedup patch serialization format, regardless of if
they are captured by the lineage() built-in or via a write operator. Previously,
all patches were stored in a separate file. Now, we always create a single file,
containing first the global trace, followed by the patches. This change also
allows us to copy the traces from the console (lineage()) and store them in a
single file for future recomputation.
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.28%. Comparing base (4b2a3ca) to head (6c4f9c1).
Report is 1 commits behind head on main.

Files Patch % Lines
...ds/runtime/controlprogram/caching/FrameObject.java 0.00% 1 Missing ⚠️
...s/runtime/controlprogram/caching/TensorObject.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2072      +/-   ##
============================================
- Coverage     70.28%   70.28%   -0.01%     
+ Complexity    41674    41669       -5     
============================================
  Files          1441     1441              
  Lines        161390   161409      +19     
  Branches      31422    31424       +2     
============================================
+ Hits         113439   113449      +10     
- Misses        39011    39016       +5     
- Partials       8940     8944       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant