feat(helm-chart): Add extraLabels to all resources

[maxforasteiro]

SUMMARY

Some orgs require all Kubernetes resources to be labeled. Adding a non-breaking change that will allow our team to use Superset helm chart without having to copy/paste and modify it ourselves.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

[villebro]

I like this idea. However, while I kind of like the global prefix, I'm wondering if it may be unnecessary. I believe we may already have some other global-like values that would seem non-global after this change. But I'm not super opinionated here.

Anyway, the main comment here applies to the labels not applying to the templates. Let's either apply them to those, too, or add a comment that they're not covered by this new property.

[maxforasteiro]

I like this idea. However, while I kind of like the global prefix, I'm wondering if it may be unnecessary. I believe we may already have some other global-like values that would seem non-global after this change. But I'm not super opinionated here.

Anyway, the main comment here applies to the labels not applying to the templates. Let's either apply them to those, too, or add a comment that they're not covered by this new property.

I agree with your comment, the global label can be misleading indeed.

[villebro]

LGTM, thanks for the improvement 🙇

[villebro]

Oh, please bump the version!

[maxforasteiro]

Oh, please bump the version!

nice catch! completely forgot 🙈

[villebro]

Seems there's a linting issue:

I didn't look closely at it, let me know if you need help resolving it.

[maxforasteiro]

@villebro fixed. Sorry for the delay