fix: bump FAB to 4.5.2

[dpgaspar]

SUMMARY

WTForms 3.2.X breaks superset with the following error:

AttributeError: 'tuple' object has no attribute 'items'

More details on: dpgaspar/Flask-AppBuilder#2279

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.91%. Comparing base (76d897e) to head (37436a1).
Report is 877 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #30688       +/-   ##
===========================================
+ Coverage   60.48%   83.91%   +23.42%     
===========================================
  Files        1931      533     -1398     
  Lines       76236    38682    -37554     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32460    -13654     
+ Misses      28017     6222    -21795     
+ Partials     2105        0     -2105     

Flag	Coverage Δ
hive	48.92% <ø> (-0.25%)	⬇️
javascript	?
mysql	76.77% <ø> (?)
postgres	76.87% <ø> (?)
presto	53.39% <ø> (-0.42%)	⬇️
python	83.91% <ø> (+20.42%)	⬆️
sqlite	76.32% <ø> (?)
unit	60.87% <ø> (+3.24%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[betodealmeida]

Thanks!

[michael-s-molina]

@dpgaspar Will we need to cherry-pick this into 4.1 which uses wtforms==3.1.2? I'm understanding that this fix is for 3.2.X which would make it not required for 4.1. Is that correct? @sadpandajoe

[villebro]

LGTM. However, should we add a lower bound here, too?

superset/pyproject.toml

Line 48 in 16981d6

"flask-appbuilder>=4.5.0, <5.0.0",

[dpgaspar]

@dpgaspar Will we need to cherry-pick this into 4.1 which uses wtforms==3.1.2? I'm understanding that this fix is for 3.2.X which would make it not required for 4.1. Is that correct? @sadpandajoe

yes, I think thats safe to say, if our users install superset without using 4.1 specific dep requirements they will automatically upgrade WTForms and FAB

[dpgaspar]

LGTM. However, should we add a lower bound here, too?

superset/pyproject.toml

Line 48 in 16981d6

"flask-appbuilder>=4.5.0, <5.0.0",

No strong opinions about it