Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: First item hovered on stacked bar #30628

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Oct 16, 2024

SUMMARY

Fixes a bug when hovering the first item of a stacked bar chart. There was a problem with the if condition which was not considering a zero index.

Follow-up of #30405.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2024-10-16 at 11 58 37 Screenshot 2024-10-16 at 11 56 28

TESTING INSTRUCTIONS

Make sure the first item of a stacked chart can be hovered.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Oct 16, 2024
@dosubot dosubot bot added the viz:charts:bar Related to the Bar chart label Oct 16, 2024
@michael-s-molina michael-s-molina merged commit c8edd1f into apache:master Oct 16, 2024
36 of 38 checks passed
sadpandajoe pushed a commit that referenced this pull request Oct 16, 2024
@sadpandajoe sadpandajoe added the review:checkpoint Last PR reviewed during the daily review standup label Oct 16, 2024
@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label Oct 17, 2024
@michael-s-molina michael-s-molina self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins size/XS v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch viz:charts:bar Related to the Bar chart
Projects
Status: Cherried
Development

Successfully merging this pull request may close these issues.

2 participants