refactor(frontend): migrate 6 Enzyme-based tests to RTL, part 2 #30281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hainenber <[email protected]>
…ableRenderer.test.tsx to RTL Signed-off-by: hainenber <[email protected]>
…sed AdhocFilterEditPopoverSimpleTabContent.test.tsx to RTL Signed-off-by: hainenber <[email protected]>
hainenber
changed the title
withAsyncVerification and associated test…Element.test.tsx to RTL Signed-off-by: hainenber <[email protected]>
hainenber
changed the title
…trol.test.jsx to RTL Signed-off-by: hainenber <[email protected]>
… to RTL Signed-off-by: hainenber <[email protected]>
hainenber
changed the title
hainenber
changed the title
…me-based DatasourceControl.test.jsx to RTL Signed-off-by: hainenber <[email protected]>
hainenber
changed the title
justinpark
requested changes
Sep 16, 2024
This reverts commit 996a671.
Got it. I've reverted its deletion. |
kgabryje
approved these changes
Sep 19, 2024
|
@justinpark , mind lifting the hold around your requested changes? |
|
hello fellas, anything I can do to have this merged? I'm about to have part 3 now :D |
|
Pinging @justinpark on Slack... hopefully we can get this through :D |
justinpark
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(frontend): migrate 6 Enzyme-based tests to RTL, part 2
SUMMARY
Remove an unused function and associated tests found when conducting Enzyme-to-RTL migration.
Also migrated a few Enzyme tests to RTL.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
GH checks with flying colors! :D
ADDITIONAL INFORMATION