Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps-dev): bump eslint-plugin-cypress from 2.11.2 to 3.4.0 in /superset-frontend + corresponding refactor #29964

Merged
merged 4 commits into from
Aug 20, 2024
Merged

build(deps-dev): bump eslint-plugin-cypress from 2.11.2 to 3.4.0 in /superset-frontend + corresponding refactor #29964

merged 4 commits into from
Aug 20, 2024

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Aug 18, 2024 •
edited
Loading

build(deps-dev): bump eslint-plugin-cypress from 2.11.2 to 3.4.0 in /superset-frontend

SUMMARY

Closes #29814

Surprisingly, this version bump has a welcoming side effect. It helps speed up E2E test execution time when compared with current latest commit in master as of writing
Before
image

After
image

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hainenber
fix(ci): refactor cypress-base codebase to comply with cypress/unsafe…
fad9aec 
…-to-chain-command rule (2nd batch)

Signed-off-by: hainenber <[email protected]>
@hainenber
fix(ci): refactor cypress-base codebase to comply with cypress/unsafe…
fa6a69c 
…-to-chain-command rule (3rd batch)

Signed-off-by: hainenber <[email protected]>
@hainenber hainenber marked this pull request as ready for review August 18, 2024 10:36
@dosubot dosubot bot added javascript Dependabot - Pull requests that update Javascript code need:tests This PR requires tests labels Aug 18, 2024
mistercrunch
mistercrunch approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistercrunch
Copy link
Member

@rusackas needs a CODEOWNERS review - oh and thanks for the flawless PR @hainenber !

@rusackas rusackas merged commit 907fc8a into apache:master Aug 20, 2024
65 of 66 checks passed
@hainenber hainenber deleted the fix-cypress-eslint-issue branch August 20, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@rusackas rusackas rusackas approved these changes

@jinghua-qa jinghua-qa Awaiting requested review from jinghua-qa jinghua-qa is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

Assignees
No one assigned
Labels
dependencies:npm javascript Dependabot - Pull requests that update Javascript code need:tests This PR requires tests size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hainenber @mistercrunch @rusackas