-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): webpack visualizer #29875
Conversation
Nice! I wonder if we should run the plugin only if a flag is passed, like we do with bundle analyzer |
@kgabryje check out the updated PR description, it all works pretty smoothly now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Given that we removed |
Happy to if you want. I only skipped it since neither Kamil nor I could get the --analyzeBundle parameter to actually WORK. We both just tweak the code to run the analyzer, it turns out. I figured this basically takes a broken tool and makes it work, and it's a dev tool rather than user-facing, so I wasn't sure how much value there is. What might cover this would actually be a Wiki page explaining what all our scripts do, since there are a TON of them, and there's not really any real documentation on the whole lot. |
SUMMARY
Some updates to the bundle analyzer in honor of @kgabryje's recent efforts. This PR does several things:
npm run bundle-stats
script to run package bundle analysisnpm run build
) exits when complete.webpack-bundle-analyzer
flag in favor of the new npm scriptwebpack-bundle-analyzer
tostatic
mode rather thanserver
mode.Here's what the new bundle analyzer looks like:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION