fix: mypy issue on py3.9 + prevent similar issues #29864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
github-actions
bot
added
the
github_actions
|
Not sure why the pre-commit job canceled here. |
rusackas
reviewed
Aug 5, 2024
mistercrunch
added a commit
that referenced
this pull request
Aug 5, 2024
in order to get #29864 through, I first need to remove the `pre-commit` check, so that PR can be merged, and add new required checks for past, future and current
mistercrunch
force-pushed
the
pre-commit-matrix
branch
from
55333d4
to
2d800a4
Compare
mistercrunch
force-pushed
the
pre-commit-matrix
branch
from
2d800a4
to
091d32f
Compare
mistercrunch
commented
Aug 5, 2024
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| import logging | |||
| import uuid | |||
| from typing import Any | |||
| from typing import Any, Union | |||
There was a problem hiding this comment.
python 3.9 doesn't support the pipe operator in type hints...
rusackas
approved these changes
Aug 5, 2024
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone reported that they had this mypy-related issue on py3.9, so I decided to fix it and to run pre-commit checks against more python versions to prevent this kind of issue from slipping into the repo