Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Dashboard): Remove unnecessary loading #29632

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from
Draft

chore(Dashboard): Remove unnecessary loading #29632

wants to merge 26 commits into from
+496 −161

Conversation

geido
Copy link
Member

@geido geido commented Jul 18, 2024 •
edited
Loading

SUMMARY

The goal of this PR is unblock the Dashboard skeleton (showing of the filters, tabs, charts containers, etc.) progressively so that the user experience is improved by showing available content sooner rather than later.

The work on this PR was becoming too large, leading to the decision of splitting the changes in smaller chunks. The thread will be updated with all related PRs.

TESTING INSTRUCTIONS

  1. The Dashboard should load normally.
  2. A Dashboard with a pre-selected filter value should load successfully.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added review:checkpoint Last PR reviewed during the daily review standup review:draft and removed review:checkpoint Last PR reviewed during the daily review standup labels Jul 18, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 1, 2024
@geido geido marked this pull request as ready for review August 1, 2024 13:47
@dosubot dosubot bot added the dashboard:performance Related to Dashboard performance label Aug 1, 2024
@geido geido requested a review from kgabryje August 1, 2024 13:51
@github-actions github-actions bot added the api Related to the REST API label Aug 6, 2024
@kgabryje kgabryje mentioned this pull request Aug 7, 2024
Open
3 tasks
@geido geido marked this pull request as draft August 19, 2024 16:22
@apache apache deleted a comment from kgabryje Aug 22, 2024
@apache apache deleted a comment from github-actions bot Aug 22, 2024
@apache apache deleted a comment from github-actions bot Sep 2, 2024
@apache apache deleted a comment from kgabryje Sep 2, 2024
@geido geido marked this pull request as ready for review September 3, 2024 14:30
@dosubot dosubot bot added the change:frontend Requires changing the frontend label Sep 3, 2024
@geido geido marked this pull request as draft September 3, 2024 14:51
@geido
Copy link
Member Author

geido commented Oct 15, 2024 •
edited
Loading

This PR will be superseded by smaller PRs. I will update this thread accordingly:

#30440
#30611

@apache apache deleted a comment from github-actions bot Oct 15, 2024
@apache apache deleted a comment from kgabryje Oct 15, 2024
@apache apache deleted a comment from kgabryje Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje Awaiting requested review from kgabryje

@justinpark justinpark Awaiting requested review from justinpark

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api Related to the REST API change:frontend Requires changing the frontend dashboard:performance Related to Dashboard performance review:draft size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geido @michael-s-molina