-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add 403 page for forbidden error #16612
feat: Add 403 page for forbidden error #16612
Conversation
Hi @junlincc, could you please help with the |
Codecov Report
@@ Coverage Diff @@
## master #16612 +/- ##
=======================================
Coverage 76.73% 76.73%
=======================================
Files 1003 1003
Lines 53875 53875
Branches 7289 7289
=======================================
Hits 41343 41343
Misses 12292 12292
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
01d3af8
to
62e6452
Compare
@duynguyenhoang hi! do you need a high resolution image for the 403 errors? |
Hi @junlincc, I think we don't need high resolution for it. |
https://www.figma.com/file/el48F3KQ9u6rtKmdZvdb36/Error-Pages?node-id=94%3A503 sorry for the delay reply, here you go! and thanks again for the contribution! |
62e6452
to
a5e077a
Compare
7df7e07
to
7dab8ac
Compare
Thank you @junlincc for providing the image. I update the PR and it is ready to review. Sorry to reply you too late. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
7dab8ac
to
ac5bdc4
Compare
Thanks for this PR! Closing and re-opening to kick-start CI, and added some reviewers in hopes that we can get this looked into! |
Hello, |
@duynguyenhoang please let us know if you revisit this PR and we'll review it. |
Hoping we can get this followed-up on one day, but for now I'll move it to Draft state. |
@duynguyenhoang I assume you're not coming back to this, so I'll close it, but let us know if you ever want to rekindle this effort! |
SUMMARY
Introduce a page for Forbidden error.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION