Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts fail to load for Trino due to query being updated #30378

Closed
3 tasks done
sadpandajoe opened this issue Sep 24, 2024 · 0 comments · Fixed by #30350
Closed
3 tasks done

Charts fail to load for Trino due to query being updated #30378

sadpandajoe opened this issue Sep 24, 2024 · 0 comments · Fixed by #30350
Assignees
Labels
data:connect:trino Related to Trino sqllab Namespace | Anything related to the SQL Lab

Comments

@sadpandajoe
Copy link
Member

Bug description

Sqlglot changes the way that some Trino queries are formatted.

How to reproduce the bug

  1. go to sqllab
  2. type in a NOT IN query
  3. Save it as a dataset
  4. view the dataset query

Notice that it goes from NOT IN to WHERE NOT ... IN which won't work with Trino

Screenshots/recordings

No response

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@sadpandajoe sadpandajoe linked a pull request Sep 24, 2024 that will close this issue
9 tasks
@dosubot dosubot bot added data:connect:trino Related to Trino sqllab Namespace | Anything related to the SQL Lab labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:connect:trino Related to Trino sqllab Namespace | Anything related to the SQL Lab
Projects
Status: Cherried
Development

Successfully merging a pull request may close this issue.

2 participants