Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WW-4520 - Add prefix for CSS classes. #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aleksandr-m
Copy link
Contributor

@aleksandr-m aleksandr-m commented Jun 30, 2015

Implements WW-4520

@asfbot
Copy link

asfbot commented Jun 30, 2015

Struts-JDK7-pull-request #44 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 2, 2015

Christoph Nenning on [email protected] replies:
Hi,

have you guys seen this jira and PR?

What do you think about the compatibility issues?

For me it would be OK to change it in 2.5, but it already scares me to
migrate my own applications ;)

https://issues.apache.org/jira/browse/WW-4520
#44

regards,
Christoph
classes.
feature/css-class-prefix
your
feature
please
ticket

This Email was scanned by Sophos Anti Virus

@asfbot
Copy link

asfbot commented Jul 2, 2015

Lukasz Lenart on [email protected] replies:
I think this too huge change and also would like to use some other
prefix than "struts-" - it can expose too much information about used
backend

2015-07-02 9:10 GMT+02:00 Christoph Nenning [email protected]:

@lukaszlenart
Copy link
Member

Hm... I wonder how hard it will be to make this configurable so we can keep backward compatibility and allow enable a custom prefix on demand.

@cnenning
Copy link
Member

cnenning commented Aug 2, 2017

I wonder how hard it will be to make this configurable

Making this configurable would be cool. But when looking at changed files, and all those different file types, i fear it would be hard.

@yasserzamani
Copy link
Member

@apache/struts-committers , I'm going to close this one as already there are users mentioning such things as an information disclosure security issue. objections?

@yasserzamani
Copy link
Member

Hm.. I see Lukasz already has mentioned about that and also as mentioned, it should be user-configurable prefix to avoid information disclosure!

@lukaszlenart
Copy link
Member

@aleksandr-m do you think it will be hard to update this PR? Or maybe create a new one?

@aleksandr-m
Copy link
Contributor Author

@lukaszlenart You mean to allow to change prefix? Do you have an idea how to do that?

@lukaszlenart
Copy link
Member

@lukaszlenart You mean to allow to change prefix? Do you have an idea how to do that?

Yes, I know we are supporting a different set of extensions and I do not have a solution at hand. Other option is to develop a new html5 theme from scratch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants