WW-5449 Make Velocity Tools dependency optional for Velocity plugin #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kusalk
force-pushed
the
7.0.x/WW-5449-remove-vel-tools
branch
from
db7dd72
to
015544a
Compare
kusalk
force-pushed
the
7.0.x/WW-5449-remove-vel-tools
branch
from
a0d3421
to
b4b4f00
Compare
kusalk
force-pushed
the
7.0.x/WW-5449-remove-vel-tools
branch
from
b4b4f00
to
ca358c5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WW-5449
I suspect many applications that use the Velocity plugin don't need the Velocity Tools dependency. By extracting the Velocity Tools related functionality into a separate class
VelocityTools.java, we give applications the ability to opt out. This class will only be initialised ifstruts.velocity.toolboxlocationis set.Velocity Tools is also still needed if using certain SiteMesh or Tiles plugin functionality. This is the case for the Showcase app so I've added Velocity Tools as an explicit dependency in that pom.
I've also refactored
VelocityManagerto be more readable.