Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-49934][SQL] Add implicit cast for accessing collated map with literal #48423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,14 @@ object CollationTypeCasts extends TypeCoercionRule {
val Seq(newLeft, newRight) = collateToSingleType(Seq(left, right))
levenshtein.withNewChildren(Seq(newLeft, newRight) ++ threshold)

case getMap @ GetMapValue(child, key) if getMap.keyType != key.dataType =>
key match {
case Literal(_, _: StringType) =>
GetMapValue(child, Cast(key, getMap.keyType))
case _ =>
getMap
}

case otherExpr @ (
_: In | _: InSubquery | _: CreateArray | _: ArrayJoin | _: Concat | _: Greatest | _: Least |
_: Coalesce | _: ArrayContains | _: ArrayExcept | _: ConcatWs | _: Mask | _: StringReplace |
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.spark.sql.collation

import org.apache.spark.SparkThrowable
import org.apache.spark.sql.{DataFrame, Row}
import org.apache.spark.sql.connector.DatasourceV2SQLBase
import org.apache.spark.sql.execution.adaptive.AdaptiveSparkPlanHelper

class CollationTypePrecedenceSuite extends DatasourceV2SQLBase with AdaptiveSparkPlanHelper {

val dataSource: String = "parquet"

private def assertThrowsError(df: => DataFrame, errorClass: String): Unit = {
val exception = intercept[SparkThrowable] {
df
}
assert(exception.getCondition === errorClass)
}

test("access collated map via literal") {
val tableName = "map_with_lit"

def selectQuery(condition: String): DataFrame =
sql(s"SELECT c1 FROM $tableName WHERE $condition = 'B'")

withTable(tableName) {
sql(s"""
|CREATE TABLE $tableName (
| c1 MAP<STRING COLLATE UNICODE_CI, STRING COLLATE UNICODE_CI>,
| c2 STRING
|) USING $dataSource
|""".stripMargin)

sql(s"INSERT INTO $tableName VALUES (map('a', 'b'), 'a')")

Seq(
"c1['A']",
"c1['A' COLLATE UNICODE_CI]",
"c1[c2 COLLATE UNICODE_CI]",
).foreach(condition =>
checkAnswer(selectQuery(condition), Seq(Row(Map("a" -> "b"))))
)

Seq(
// different explicit collation
"c1['A' COLLATE UNICODE]",
// different implicit collation
"c1[c2]",
).foreach(condition =>
assertThrowsError(selectQuery(condition), "DATATYPE_MISMATCH.UNEXPECTED_INPUT_TYPE")
)
}
}
}