[SPARK-49615] Bugfix: Make ML column schema validation conforms with spark config spark.sql.caseSensitive.
#48398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weichen Xu <[email protected]>
cloud-fan
reviewed
Oct 9, 2024
mllib/src/main/scala/org/apache/spark/ml/util/SchemaUtils.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Oct 9, 2024
sql/api/src/main/scala/org/apache/spark/sql/types/StructType.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Oct 9, 2024
Signed-off-by: Weichen Xu <[email protected]>
WeichenXu123
changed the title
spark.sql.caseSensitive configspark.sql.caseSensitive.
cloud-fan
reviewed
Oct 10, 2024
mllib/src/main/scala/org/apache/spark/ml/util/SchemaUtils.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Oct 10, 2024
Signed-off-by: Weichen Xu <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
cloud-fan
reviewed
Oct 11, 2024
Signed-off-by: Weichen Xu <[email protected]>
cloud-fan
approved these changes
Oct 11, 2024
Signed-off-by: Weichen Xu <[email protected]>
|
merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Bugfix: Make ML column schema validation conforms with spark config
spark.sql.caseSensitive.Why are the changes needed?
Bugfix: Make ML column schema validation conforms with spark config
spark.sql.caseSensitive.Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
N/A