[SPARK-49856][SQL] Refactor the compileExpression of JdbcDialect for simplify the subclass. #48322
+17
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beliefer
force-pushed
the
SPARK-49856
branch
3 times, most recently
from
65dda9d
to
3a05358
Compare
|
ping @cloud-fan |
cloud-fan
reviewed
Oct 9, 2024
| /** | ||
| * Converts V2 expression to String representing a SQL expression. | ||
| * @param expr The V2 expression to be converted. | ||
| * @return Converted value. | ||
| */ | ||
| @Since("3.3.0") | ||
| def compileExpression(expr: Expression): Option[String] = { | ||
| val jdbcSQLBuilder = new JDBCSQLBuilder() |
There was a problem hiding this comment.
I'm not sure if it's worthwhile to add a new API for saving like copying 10 line of code... but I don't have a strong preference on this.
cc @milastdbx
…simplify the subclass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to refactor the
compileExpressionofJdbcDialectso that simplify the subclass.Why are the changes needed?
Current definition of
compileExpressionworks with theJDBCSQLBuilder. The JDBC dialect should override thecompileExpressionwith almost identical code if JDBC dialect want supports special SQL syntax.This PR adds the function
jdbcSQLBuilder(): JDBCSQLBuilder, so that the subclass could reuse the code come from parent.Does this PR introduce any user-facing change?
'No'.
New feature.
How was this patch tested?
GA tests.
Was this patch authored or co-authored using generative AI tooling?
'No'.