[SPARK-47221][SQL] Uses signatures from CsvParser to AbstractParser #45328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
approved these changes
Feb 29, 2024
|
+1, LGTM. Merging to master. |
TakawaAkirayo
pushed a commit
to TakawaAkirayo/spark
that referenced
this pull request
Mar 4, 2024
### What changes were proposed in this pull request? This PR proposes to change signature `CsvParser` to `AbstractParser` (its parent class). ### Why are the changes needed? - It's better to use higher classes if they fit for better extendibility and maintenance. - Univocity parser became inactive for the last three years, and we're missing bug fixes such as uniVocity/univocity-parsers#533. We should probably leverage their interface, and implement it in Spark for bug fixes and further performance improvement. This is a basework. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing test cases should cover. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45328 from HyukjinKwon/SPARK-47221. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Max Gekk <[email protected]>
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
### What changes were proposed in this pull request? This PR proposes to change signature `CsvParser` to `AbstractParser` (its parent class). ### Why are the changes needed? - It's better to use higher classes if they fit for better extendibility and maintenance. - Univocity parser became inactive for the last three years, and we're missing bug fixes such as uniVocity/univocity-parsers#533. We should probably leverage their interface, and implement it in Spark for bug fixes and further performance improvement. This is a basework. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing test cases should cover. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45328 from HyukjinKwon/SPARK-47221. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to change signature
CsvParsertoAbstractParser(its parent class).Why are the changes needed?
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing test cases should cover.
Was this patch authored or co-authored using generative AI tooling?
No.