Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make ConsumeQueueStore bottom most compression type configurable #8841

Merged

Conversation

lizhanhui
Copy link
Contributor

Which Issue(s) This PR Fixes

to #8829

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.39%. Comparing base (49e23e1) to head (683efe6).

Files with missing lines Patch % Lines
...ache/rocketmq/store/config/MessageStoreConfig.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8841      +/-   ##
=============================================
+ Coverage      47.37%   47.39%   +0.01%     
- Complexity     11599    11602       +3     
=============================================
  Files           1284     1284              
  Lines          90018    90025       +7     
  Branches       11585    11585              
=============================================
+ Hits           42648    42666      +18     
+ Misses         42121    42111      -10     
+ Partials        5249     5248       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuyou001 fuyou001 merged commit 1e0b08f into apache:develop Oct 18, 2024
11 checks passed
@lizhanhui lizhanhui deleted the configure-cq-last-level-compression-algo branch October 18, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants