Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[logstash-integration] fix: build fails when logstash version number unit >= 10 #935

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

imfms
Copy link

@imfms imfms commented Jul 24, 2024

What is the purpose of the change

[logstash-integration] fix: build fails when logstash version number unit >= 10

Brief changelog

only change some file match rule ?.?.? -> *.*.*

Verifying this change

logstash '7.17.21'

  • build with change before: cannot find symbol ... (because logstash-core-7.17.23.jar can't match xxx-?.?.?.jar, so it's not in classpath)
  • build with change after: ... (because logstash-core-7.17.23.jar can match xxx-*.*.*.jar, it's in classpath)

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant