-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/modbus optimizer #1744
Feature/modbus optimizer #1744
Conversation
…timizer in order to eliminate unneeded dependencies.
…r the optimized Modbus driver.
@chrisdutz Yeah have to spend some time on fixing things when it comes to using the PlcValues, the Modbus write PR will include some fixes for it. But for now it passes the tests. |
Did I break anything with my addition? |
No, it was just a Byte Array branch in the code gen that hadn't been used before. It was generating code that had a syntax error in it, that's why black couldn't reformat the file. By the way we are using black to firstly check for syntax errors, as well as clean up some of the formatting in the code gen output. That way we can be lazy and don't have to get the formatting in the code gen output exactly right. |
|
…eature/modbus-optimizer # Conflicts: # plc4py/plc4py/protocols/modbus/readwrite/DataItem.py # plc4py/plc4py/protocols/modbus/readwrite/ModbusDataType.py # plc4py/plc4py/protocols/simulated/readwrite/DataItem.py
…dressable in one request to the modbus driver.
As long as the output gives you a hint to what the problem is ... admittedly I was a bit lost and commented out black in order to get a sensible error report. |
Implemented an optimizer for Modbus in Java, that groups together individual items and loads chunks of bytes.
This needed quite a bit of updating which also had an effect on the generated code of almost every language we have.
However with this update the read speed of the ManualModbusTest increased by a factor of more than 10.