Remove support for var-args in plc4j #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splatch
force-pushed
the
plc4j-without-var-arg
branch
from
acf938a
to
27f74fa
Compare
|
Checked it out, built it locally and ran the manual tests against my equipment. All worked fine. Also had a look at the changes in the drivers and liked what I saw. |
|
Great, will rebase and push changes. |
|
I think if you rebase a branch that you already pushed, that's when you get these nasty github warnings ... I only rebase "develop" and merge all others ... but please ... don't merge before the build passes ;-) |
splatch
force-pushed
the
plc4j-without-var-arg
branch
from
27f74fa
to
cdc17a4
Compare
|
|
|
You push changes faster than CI completes jobs. :-) |
…cks of generated contents. BREAKING CHANGE: Removed `staticParse(io, ... args)` methods. Signed-off-by: Łukasz Dywicki <[email protected]>
Signed-off-by: Łukasz Dywicki <[email protected]>
splatch
force-pushed
the
plc4j-without-var-arg
branch
from
cdc17a4
to
aaf78d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.