Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CANopen driver fixes #1446

Merged
merged 1 commit into from
Mar 11, 2024
Merged

CANopen driver fixes #1446

merged 1 commit into from
Mar 11, 2024

Conversation

splatch
Copy link
Contributor

@splatch splatch commented Mar 11, 2024

Small updates needed to get driver working again after changes in 0.11/0.12 releases.

@splatch splatch self-assigned this Mar 11, 2024
@splatch splatch marked this pull request as ready for review March 11, 2024 18:03
@splatch splatch requested a review from chrisdutz March 11, 2024 18:04
@splatch
Copy link
Contributor Author

splatch commented Mar 11, 2024

@chrisdutz I've switched it from draft as it runs stable with my machine, could you give a spin to it? These are minor change but I enable some of new tests which should not break under mac/windows etc..

Copy link
Contributor

@chrisdutz chrisdutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only changes I really care about are the ones in SPI and it seems your renaming actually made it comply with the naming convention in API ... so I'm fine with all of it.

@splatch
Copy link
Contributor Author

splatch commented Mar 11, 2024

Great, I'll try to push one more thing related to tag handling for generic can and then, if CI/CD is happy, merge it.

@splatch splatch merged commit eaa0fe1 into develop Mar 11, 2024
32 of 33 checks passed
@splatch splatch deleted the canopen-driver-fixes branch March 11, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants