Corrects the call to generate events that were commented. Tests again… #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had a look and it seems all changes only have an effect on the Event-based PLCs ... none of which I have. So I have no objections to merging this as is ;-) |
sruehl
reviewed
Feb 12, 2024
| if (parameter instanceof S7ParameterModeTransition) { | ||
| // TODO: The eventQueue is only drained in the S7ProtocolEventLogic.ObjectProcessor and here only messages of type S7Event are processed, so S7PayloadUserDataItem elements will just be ignored. | ||
| //eventQueue.add(parameter); | ||
| System.out.println(msg); |
There was a problem hiding this comment.
maybe remove that before merge
sruehl
reviewed
Feb 12, 2024
| if (parameterUDItem instanceof S7ParameterUserDataItemCPUFunctions) { | ||
|
|
There was a problem hiding this comment.
why are there so many empty lines now?
sruehl
reviewed
Feb 12, 2024
plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java
Outdated
Show resolved
Hide resolved
This was referenced Feb 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects call to generate asynchronous events for the S7 driver.