Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plc4j-driver-opcua: Re-enable a disabled test #1159

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

takraj
Copy link
Contributor

@takraj takraj commented Oct 18, 2023

After running it 600 times in a row with success, it does not seem to be flaky anymore.

After running it 600 times in a row with success, it does not seem to be flaky anymore.
@sruehl
Copy link
Contributor

sruehl commented Oct 18, 2023

Yeah, I guess we can enable it then again. However there was something going on on different platforms. If @chrisdutz doesn't have any objection I think it is fine to merge

@sruehl
Copy link
Contributor

sruehl commented Oct 18, 2023

@takraj oh and just a minor nitpick: Try to write your commits like test(plc4j/opcua): bla bla (https://www.conventionalcommits.org/en/v1.0.0/). I usually edit them before merge but this way it can't be forgotten :)

@chrisdutz
Copy link
Contributor

I think some of the tests in OPC-UA were not flaky on all platforms ... there is a number of tests, that simply don't run on Docker or Paralells VMs (No idea why) ... so if we comment in this test and it stats causing problems, we just add the comments to exclude them on Docker or Paralells.

@chrisdutz
Copy link
Contributor

Mabe in general it would be cool, when re-enabling OPC-UA tests, to add a comment that they were re-enabled and if they were causing problems, that first Docker and Paralells should be checked ... this way I don't have to track down the problem for the 10th time ;)

@sruehl sruehl merged commit 17219ab into apache:develop Oct 18, 2023
12 checks passed
@takraj takraj deleted the pr/opcua-enable-multithreaded-test branch October 18, 2023 14:41
@takraj
Copy link
Contributor Author

takraj commented Oct 18, 2023

@takraj oh and just a minor nitpick: Try to write your commits like test(plc4j/opcua): bla bla (https://www.conventionalcommits.org/en/v1.0.0/). I usually edit them before merge but this way it can't be forgotten :)

@sruehl OK, will do so. I was looking for such rules in the Contributing guide, but have not found any.

@sruehl
Copy link
Contributor

sruehl commented Oct 18, 2023

Yeah, good point, I should add that there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants