Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opcua): Attempting to fix cyclic subscriptions #1124

Merged
merged 1 commit into from
Oct 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,9 @@ public static Variant staticParse(ReadBuffer readBuffer) throws ParseException {

// Switch Field (Depending on the discriminator values, passes the instantiation to a sub-type)
VariantBuilder builder = null;
if (EvaluationHelper.equals(VariantType, (byte) 1)) {
if (EvaluationHelper.equals(VariantType, (byte) 0)) {
builder = VariantNull.staticParseVariantBuilder(readBuffer);
} else if (EvaluationHelper.equals(VariantType, (byte) 1)) {
builder = VariantBoolean.staticParseVariantBuilder(readBuffer, arrayLengthSpecified);
} else if (EvaluationHelper.equals(VariantType, (byte) 2)) {
builder = VariantSByte.staticParseVariantBuilder(readBuffer, arrayLengthSpecified);
Expand Down
2 changes: 2 additions & 0 deletions protocols/opcua/src/main/xslt/opc-manual.xsl
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,8 @@
[simple bit arrayDimensionsSpecified]
[discriminator uint 6 VariantType]
[typeSwitch VariantType,arrayLengthSpecified
['0' VariantNull
]
['1' VariantBoolean (bit arrayLengthSpecified)
[optional int 32 arrayLength 'arrayLengthSpecified']
[array byte value count 'arrayLength == null ? 1 : arrayLength']
Expand Down
Loading