From 7ca76028c477f2cdd49a72876336ddde96da2555 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christoph=20Sch=C3=A4bel?= <5277936+schaebo@users.noreply.github.com> Date: Fri, 2 Feb 2024 07:46:26 +0100 Subject: [PATCH] fix(plc4j/eip): Remove unnecessary Thread.sleep (#1374) --- .../plc4x/java/eip/base/protocol/EipProtocolLogic.java | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/plc4j/drivers/eip/src/main/java/org/apache/plc4x/java/eip/base/protocol/EipProtocolLogic.java b/plc4j/drivers/eip/src/main/java/org/apache/plc4x/java/eip/base/protocol/EipProtocolLogic.java index 74d2b7c427a..2cef5f8a256 100644 --- a/plc4j/drivers/eip/src/main/java/org/apache/plc4x/java/eip/base/protocol/EipProtocolLogic.java +++ b/plc4j/drivers/eip/src/main/java/org/apache/plc4x/java/eip/base/protocol/EipProtocolLogic.java @@ -473,12 +473,6 @@ private CompletableFuture readWithoutMessageRouter(PlcReadReque // Finish the request-transaction. transaction.endRequest(); })); - // TODO: Remove this ... - try { - Thread.sleep(1000); - } catch (InterruptedException e) { - throw new RuntimeException(e); - } } catch (SerializationException e) { e.printStackTrace(); } @@ -800,7 +794,7 @@ private PlcValue parsePlcValue(EipTag tag, ByteBuf data, CIPDataTypeCode type) { case LINT: list.add(new PlcLINT(Long.reverseBytes(data.getLong(index)))); index += type.getSize(); - break; + break; case BOOL: list.add(new PlcBOOL(data.getBoolean(index))); index += type.getSize(); @@ -853,7 +847,7 @@ private PlcValue parsePlcValue(EipTag tag, ByteBuf data, CIPDataTypeCode type) { // This is a different type of STRUCTURED data } return null; - } + } default: return null; }