diff --git a/plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/config/OpcuaConfiguration.java b/plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/config/OpcuaConfiguration.java index 16b813c5ae8..5f9b480f056 100644 --- a/plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/config/OpcuaConfiguration.java +++ b/plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/config/OpcuaConfiguration.java @@ -63,9 +63,6 @@ public class OpcuaConfiguration implements Configuration { @ConfigurationParameter("keyStoreFile") private String keyStoreFile; - @ConfigurationParameter("certDirectory") - private String certDirectory; - @ConfigurationParameter("keyStorePassword") private String keyStorePassword; private X509Certificate serverCertificate; @@ -109,10 +106,6 @@ public String getPassword() { return password; } - public String getCertDirectory() { - return certDirectory; - } - public SecurityPolicy getSecurityPolicy() { return securityPolicy; } @@ -165,7 +158,6 @@ public String toString() { ", password='" + (password != null ? "******" : null) + '\'' + ", securityPolicy='" + securityPolicy + '\'' + ", keyStoreFile='" + keyStoreFile + '\'' + - ", certDirectory='" + certDirectory + '\'' + ", keyStorePassword='" + (keyStorePassword != null ? "******" : null) + '\'' + ", limits=" + limits + '}'; diff --git a/plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/context/CertificateKeyPair.java b/plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/context/CertificateKeyPair.java index f166d77ba44..29caf9fd557 100644 --- a/plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/context/CertificateKeyPair.java +++ b/plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/context/CertificateKeyPair.java @@ -19,6 +19,7 @@ package org.apache.plc4x.java.opcua.context; import io.vavr.control.Try; +import java.security.GeneralSecurityException; import java.security.PrivateKey; import org.bouncycastle.asn1.x509.GeneralName; @@ -35,7 +36,7 @@ public class CertificateKeyPair { private final X509Certificate certificate; private final byte[] thumbprint; - public CertificateKeyPair(KeyPair keyPair, X509Certificate certificate) throws Exception { + public CertificateKeyPair(KeyPair keyPair, X509Certificate certificate) throws GeneralSecurityException { this.keyPair = keyPair; this.certificate = certificate; MessageDigest messageDigest = MessageDigest.getInstance("SHA-1"); diff --git a/plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/context/OpcuaDriverContext.java b/plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/context/OpcuaDriverContext.java index 3bc503f4eec..c8774037d95 100644 --- a/plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/context/OpcuaDriverContext.java +++ b/plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/context/OpcuaDriverContext.java @@ -19,6 +19,10 @@ package org.apache.plc4x.java.opcua.context; +import java.io.FileNotFoundException; +import java.io.IOException; +import java.nio.file.Paths; +import java.security.GeneralSecurityException; import java.util.Optional; import org.apache.commons.codec.digest.DigestUtils; import org.apache.plc4x.java.api.exceptions.PlcRuntimeException; @@ -73,18 +77,21 @@ public class OpcuaDriverContext implements DriverContext, HasConfiguration tuple.getKey() + "=" + tuple.getValue()) + .map(tuple -> tuple.getKey() + "=" + URLEncoder.encode(tuple.getValue(), Charset.defaultCharset())) .collect(Collectors.joining(paramDivider)); - return tcpConnectionAddress + paramSectionDivider + connectionParams; default: throw new IllegalStateException();