PHOENIX-7458 : Create new SYSTEM tables for tracking CDC Stream metadata #2025
+131
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palashc
commented
Nov 9, 2024
| PARTITION_ID + " VARCHAR NOT NULL," + | ||
| // Non-PK columns | ||
| PARENT_PARTITION_ID + " VARCHAR," + | ||
| PARTITION_START_TIME + " BIGINT," + |
There was a problem hiding this comment.
@virajjasani Does BIGINT make sense for start/end time since we can use (region_id) which is timestamp that we plan to use as sequence number? Or does it have to be Date as per the design doc?
There was a problem hiding this comment.
I see, in this case we can use LONG directly instead of DATE. Timestamp value (regionId) is anyways long.
virajjasani
reviewed
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.